fix: Renaming google plus entry to google groups in admin content social link page #3588
Conversation
|
@maze-runnar It looks good, I have pushed a test commit to |
|
@maze-runnar Can you also rename the |
Thanks @kushthedude |
I have changed input_id , But i am not sure about models , can you please guide me . |
kushthedude
changed the title
In |
| <label>{{t 'Google Groups'}}</label> | ||
| {{widgets/forms/link-input | ||
| segmentedLink=socials.segmentedGoogleUrl | ||
| inputId='google_plus' |
ok , thanks |
|
@kushthedude sir i have made changes. Do i need to make any further changes ? |
| </div> | ||
| <div class="field"> | ||
| <label>{{t 'Google +'}}</label> | ||
| <label>{{t 'Google Groups'}}</label> |
There was a problem hiding this comment.
Why Plural?
Groups implies you can add multiple groups, but there is only one text field. Keep it Group
|
@maze-runnar Please change |
| {{widgets/forms/link-input | ||
| segmentedLink=socials.segmentedGoogleUrl | ||
| inputId='google_plus' | ||
| inputId='google_groups' |
There was a problem hiding this comment.
Change here too else validation wont work
|
I have changed google groups to google group but i think its actual name is google groups not group. |
3 participants
Fixes #3584
Short description of what this resolves:
It changes the google plus entry to google groups in admin/content page .Also fixes the required regex expression for google goups url (https://groups.google.com/forum/#!forum/open-event).Also updated the warning messages shows in box after filling wrong url from "enter a valid google plus url" to "enter a valid google groups url"
Changes proposed in this pull request:
-changed google plus entry in (https://eventyay.com/admin/content) to google groups entry.
on entering the wrong url -
on entering the right url -
Checklist
developmentbranch.