fix: Increase page[size] to render all form fields.

[prateekj117]

Fixes #3585

Short description of what this resolves:

In total, all custom fields related to an event (speaker custom fields + session custom fields + attendee custom fields) can have a size of 55, while we only fetch 50, which causes us to lose some fields rendering from server.

Changes proposed in this pull request:

• Changed it to 0, to render all custom fields associated with that event.

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[prateekj117]

@mariobehling @iamareebjamal Please review.

[iamareebjamal]

Change it to 0

[kushthedude]

Provide a screenshot without jumbled fields and all fields rendering

[prateekj117]

@iamareebjamal Done.

[kushthedude]

Also page size 0 don't make any sense, rather then looking for a short fix , make the form y-scrollable

[kushthedude]

@iamareebjamal Done.

@prateekj117 I think you didn't read and understand the comment. Also I suggest you to please go through Contribution & Best practices Guide once again. As I was already working on the issue and you dropped a comment made a PR without even notifying me.

[prateekj117]

@kushthedude Check gitter.

[iamareebjamal]

It was an urgent issue and a small fix. @kushthedude You already have a lot of issues assigned.

Also, why page[size] 0 doesn't make any sense? I have suggested that.

How is that a temporary fix? What else can be a "correct" solution? The issue simply is that jsonapi limits the results by page size, so it needs to be set to 0 which means don't limit the results

[iamareebjamal]

And yes, make the form y-scrollable @prateekj117 if its size is greater than the viewport

[kushthedude]

How is that a temporary fix? What else can be a "correct" solution? The issue simply is that jsonapi limits the results by page size, so it needs to be set to 0 which means don't limit the results

I didnt know about that. Also setting page[size]:0 would break the inconsistency and if the issue is only because of the insufficient page[size], We can make the form scrollable or wrap it up in a container and make the container scrollable as we have done in tables.
Also if page[size]:0 is the only solution presently, lets go with it

Also @iamareebjamal you will have to manually fix the order of fields in session form as it was done earlier by @CosmicCoder96 .

[iamareebjamal]

setting page[size]:0 would break the inconsistency

Why?

We can make the form scrollable or wrap it up in a container and make the container scrollable as we have done in tables.

If you do that, and keep page[size] = 50, all fields won't be fetched

you will have to manually fix the order of fields in session form

Can you please paste the expected order of the fields? And why is it not present in the API/frontend?

[prateekj117]

Before:

After:

@iamareebjamal Please review.

[iamareebjamal]

Session Form screenshots?

[prateekj117]

@iamareebjamal Not missing any field in session form.

[iamareebjamal]

Issue says that there are missing elements in it

[prateekj117]

@iamareebjamal In case of sessions, I see all fields in the form as selected in the screenshots provided by @mariobehling Sir in the issue.
It might be the case that the 5-6 custom fields which were not given by API had session type in case of a given event.