Skip to content

fix: event sort by name to actually sort by name #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 5, 2019
Merged

fix: event sort by name to actually sort by name #3552

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
161150d
fix(Event sort): Fix event sort by name to acctually sort by name
Oct 11, 2019
bce964b
fix(Event list): Fix event sort by name
Oct 15, 2019
b6c3ad4
fix(Table sorting): Fix table sorting by name on admin/events
Oct 16, 2019
f5636bc
fix(Table sorting): Fix table sorting by name on manage events
Oct 16, 2019
276be32
test(event general): fix event test regarding new changes
Oct 18, 2019
bebbce8
Merge branch 'development' into Fix-#3499
kushthedude Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/tables/headers/sort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default class extends Component {
super.didInsertElement(...arguments);
if (this.sorts && this.sorts[0] && this.sorts[0].valuePath === this.column.valuePath) {
this.setProperties({
sortBy : kebabCase(this.sorts[0].valuePath), // Ensures field names are server compatible with sort
sortBy : this.sorts[0].valuePath === 'identifier' ? 'name' : kebabCase(this.sorts[0].valuePath), // Ensures field names are server compatible with sort
sortDir : this.sorts[0].isAscending ? 'ASC' : 'DSC'
});

Expand Down