Skip to content

fix:add sort options to Speakers Table #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix:add sort options to Speakers Table #3539

merged 1 commit into from
Oct 1, 2019

Conversation

amreshk005
Copy link
Contributor

Fixes #3483

Short description of what this resolves:

Added sort button to speakers Table
Screen Shot 2019-09-27 at 8 55 27 PM

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Sep 27, 2019
@amreshk005
Copy link
Contributor Author

amreshk005 commented Sep 27, 2019 •
edited
Loading

@kushthedude @shreyanshdwivedi I have fixed the issue.

Please check it out.

@amreshk005 amreshk005 closed this Sep 27, 2019
@amreshk005 amreshk005 reopened this Sep 27, 2019
kushthedude
kushthedude suggested changes Sep 27, 2019
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indentation

@amreshk005
Copy link
Contributor Author

amreshk005 commented Sep 27, 2019 •
edited
Loading

Fix the indentation

@kushthedude I have fixed the indentation

@amreshk005
Indentation Fixed
4dfbf1a 
lint is done by command

Indentation is Fixed
uds5501
uds5501 approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@amreshk005 amreshk005 requested a review from kushthedude October 1, 2019 02:48
@kushthedude kushthedude merged commit f6dfef7 into fossasia:development Oct 1, 2019
@kushthedude
Copy link
Member

@amreshk005 please use a meaningful commit name from next time when your force push

@amreshk005
Copy link
Contributor Author

@amreshk005 please use a meaningful commit name from next time when your force push

Ok, I will take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Speakers Table: Show sort action buttons in Speakers Table

4 participants

@amreshk005 @kushthedude @uds5501 @shreyanshdwivedi