Skip to content

fix: adding id to all notify objects in the webapp #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 19, 2019
Merged

fix: adding id to all notify objects in the webapp #3536

merged 11 commits into from
Nov 19, 2019

Conversation

kushthedude
Copy link
Member

fixes #3437

@auto-label auto-label bot added the fix label Sep 26, 2019
@kushthedude kushthedude changed the title fix: adding id to all notify objects in the webapp [wip]fix: adding id to all notify objects in the webapp Sep 26, 2019
@auto-label auto-label bot removed the fix label Sep 26, 2019
@kushthedude kushthedude reopened this Oct 14, 2019
@fossasia fossasia deleted a comment Oct 24, 2019
@kushthedude kushthedude changed the title [wip]fix: adding id to all notify objects in the webapp fix: adding id to all notify objects in the webapp Oct 24, 2019
@auto-label auto-label bot added the fix label Oct 24, 2019
@kushthedude
Copy link
Member Author

@iamareebjamal Please review and merge

@kushthedude kushthedude removed the request for review from abhinavk96 October 30, 2019 06:18
abhinavk96
abhinavk96 suggested changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the naming consistent, if you are including the error keyword include it for all of them.

@kushthedude
Copy link
Member Author

@CosmicCoder96 Made the naming consistent

error->error
success->succ
and many little keyword

@kushthedude kushthedude requested review from abhinavk96, iamareebjamal and mariobehling and removed request for abhinavk96 and mariobehling November 5, 2019 22:41
@kushthedude kushthedude closed this Nov 6, 2019
@kushthedude kushthedude reopened this Nov 6, 2019
@kushthedude
Copy link
Member Author

@iamareebjamal

@iamareebjamal iamareebjamal merged commit be64f4e into fossasia:development Nov 19, 2019
@kushthedude kushthedude deleted the noti branch December 19, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

@iamareebjamal iamareebjamal Awaiting requested review from iamareebjamal

@mariobehling mariobehling Awaiting requested review from mariobehling

1 more reviewer

@uds5501 uds5501 uds5501 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix the multiple notification issue across the web-app

4 participants

@kushthedude @abhinavk96 @uds5501 @iamareebjamal