Skip to content

fix: Nav Bar - Profile Tab works in Mobile View #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2019
Merged

fix: Nav Bar - Profile Tab works in Mobile View #3535

merged 3 commits into from
Oct 18, 2019

Conversation

@reetamnandi
Copy link
Contributor

@reetamnandi reetamnandi commented Sep 26, 2019 •
edited
Loading

Fixes #3526

Short description of what this resolves:

Profile Tab on mobile now opens the required Profile page.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@reetamnandi reetamnandi changed the title Profile tab fix: Nav Bar - Profile Tab works in Mobile View Sep 26, 2019
@auto-label auto-label bot added the fix label Sep 26, 2019
@uds5501
Copy link
Contributor

uds5501 commented Sep 26, 2019

@Reetam-Nandi The fix looks good, just squash your commits and please update the changes proposed in your pull request

@reetamnandi
Copy link
Contributor Author

@uds5501 Commits squashed, changes updated.

uds5501
uds5501 previously approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changes proposed in PR template otherwise LGTM 👍

kushthedude
kushthedude suggested changes Sep 26, 2019
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2019-09-27 at 12 59 36 AM

Make the anchor tag inside div tag.

@kushthedude
Copy link
Member

Fix this space created due to use of class=item twice
Screenshot 2019-09-27 at 1 17 24 AM

uds5501
uds5501 approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uds5501 uds5501 merged commit 2f7ef70 into fossasia:development Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

3 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nav Bar: Profile Tab not working in mobile view

4 participants

@reetamnandi @uds5501 @kushthedude @shreyanshdwivedi