Skip to content

Conversation

Hardik500
Copy link
Member

Fixes #3513

Short description of what this resolves:

Changed every occurrence of 'Add Session Details' to 'Add Session'

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshot

Screenshot from 2019-09-15 14-44-28

@Hardik500
Copy link
Member Author

I don't know why Codacy/PR Quality Review. Even when I click on details then on analyse it just keeps on analysing. Can someone help me with it.

@kushthedude
Copy link
Member

@Hardik500 Before making any more PR, I request you to read FOSSASIA's Contribution & Best practices Guide. You didn't drop any comment to the issue before making a PR. Such behaviour is discouraged. Please follow best practices from next time

@Hardik500
Copy link
Member Author

Sorry @kushthedude I did it cause I was way too excited. I'll definitely remember it next time or if you want I can do it now.
But still can you please tell me what's the issue with Codacy?

@kushthedude
Copy link
Member

Sorry @kushthedude I did it cause I was way too excited. I'll definitely remember it next time or if you want I can do it now.
But still can you please tell me what's the issue with Codacy?

Dont change the .po files and follow Semantic PR Naming

@Hardik500
Copy link
Member Author

Hardik500 commented Sep 15, 2019

Sorry @kushthedude I did it cause I was way too excited. I'll definitely remember it next time or if you want I can do it now.
But still can you please tell me what's the issue with Codacy?

Dont change the .po files and follow Semantic PR Naming

What about the messages.pot file?

Should I close this PR and create a new one?

@kushthedude
Copy link
Member

kushthedude commented Sep 15, 2019

Sorry @kushthedude I did it cause I was way too excited. I'll definitely remember it next time or if you want I can do it now.
But still can you please tell me what's the issue with Codacy?

Dont change the .po files and follow Semantic PR Naming

What about the messages.pot file?

Should I close this PR and create a new one?

Make changes in the same and dont change any other file except .hbs

@Hardik500 Hardik500 changed the title Changed 'Add Session Details' to 'Add Session' (#3513) style: Changed 'Add Session Details' to 'Add Session' (#3513) Sep 15, 2019
@abhinavk96 abhinavk96 changed the title style: Changed 'Add Session Details' to 'Add Session' (#3513) fix: Changed 'Add Session Details' to 'Add Session' (#3513) Sep 19, 2019
@auto-label auto-label bot added the fix label Sep 19, 2019
@abhinavk96 abhinavk96 merged commit 2bfaaa8 into fossasia:development Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call for Speakers: Instead of "Add Session Details" there should be only "Add Session"

3 participants