Skip to content

Conversation

amreshk005
Copy link
Contributor

@amreshk005 amreshk005 commented Sep 10, 2019

Fixes #3477

Short description of what this resolves:

  • Now the overlapping problem is solved in the Event Dashboard.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screen Shot 2019-09-10 at 7 19 51 PM

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the best practices before you propose a PR. For example, you have to provide a screenshot here.

@amreshk005
Copy link
Contributor Author

@mrsaicharan1 I have added the screenshot.

Please check it out.

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the redundant changes from app/routes/account/billing/payment-info.js
&
app/styles/pages/public-event.scss
Otherwise, this LGTM.

@amreshk005
Copy link
Contributor Author

@mrsaicharan1 I have modified the commit.

Please look over it.

mrsaicharan1
mrsaicharan1 previously approved these changes Sep 10, 2019
@mrsaicharan1 mrsaicharan1 changed the title Event Dashboard: overlapping columns in Tickets/Attendees #3477 fix: Fix overlapping columns in event dashboard Sep 10, 2019
@auto-label auto-label bot added the fix label Sep 10, 2019
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the Semantic PR Naming rules from next time. I've changed it manually for now. Whenever an update is released, this fix gets excluded if you don't name it properly.
https://github.com/probot/semantic-pull-requests

valuePath : 'lastname'
valuePath : 'lastname',
width : 90

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this extra space

@amreshk005
Copy link
Contributor Author

@kushthedude I have fixed the extra spaced

Please check it out.

@kushthedude
Copy link
Member

@kushthedude I have fixed the extra spaced

Please check it out.

Give screenshot in the smallest screen size or mobile screen to check the overlap.

@abhinavk96 abhinavk96 merged commit 50940d3 into fossasia:development Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event Dashboard: overlapping columns in Tickets/Attendees

4 participants