-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Fix overlapping columns in event dashboard #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read the best practices before you propose a PR. For example, you have to provide a screenshot here.
@mrsaicharan1 I have added the screenshot. Please check it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the redundant changes from app/routes/account/billing/payment-info.js
&
app/styles/pages/public-event.scss
Otherwise, this LGTM.
0504f3c
to
22c2e43
Compare
@mrsaicharan1 I have modified the commit. Please look over it. |
Tickets/Attendees
#3477There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care of the Semantic PR Naming rules from next time. I've changed it manually for now. Whenever an update is released, this fix gets excluded if you don't name it properly.
https://github.com/probot/semantic-pull-requests
valuePath : 'lastname' | ||
valuePath : 'lastname', | ||
width : 90 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this extra space
@kushthedude I have fixed the extra spaced Please check it out. |
Give screenshot in the smallest screen size or mobile screen to check the overlap. |
Fixes #3477
Short description of what this resolves:
Checklist
development
branch.