Skip to content

fix: Fixing overlapping columns in discount codes #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2019
Merged

fix: Fixing overlapping columns in discount codes #3516

merged 2 commits into from
Sep 19, 2019

Conversation

saksham2410
Copy link
Member

@saksham2410 saksham2410 commented Sep 9, 2019 •
edited
Loading

Fixes #3478

Short description of what this resolves:

  • Increased column width to accommodate every detail.

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shreyanshdwivedi
Copy link
Member

shreyanshdwivedi commented Sep 9, 2019 •
edited
Loading

@saksham2410 please follow best practices and add a screenshot for the changes made in the PR description

@saksham2410
Copy link
Member Author

@saksham2410 please follow best practices and add a screenshot for the changes made in the PR description

Will take care from next time

@saksham2410 saksham2410 changed the title Fixing overlapping columns in discount codes fix: Fixing overlapping columns in discount codes Sep 12, 2019
@auto-label auto-label bot added fix labels Sep 12, 2019
kushthedude
kushthedude approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

uds5501
uds5501 approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@abhinavk96 abhinavk96 merged commit b497611 into fossasia:development Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

3 more reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@uds5501 uds5501 uds5501 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ticket Dashboard: Overlapping columns in Tickets/Discount-Codes

5 participants

@saksham2410 @shreyanshdwivedi @abhinavk96 @uds5501 @kushthedude