Skip to content

Conversation

vishakhanihore
Copy link
Contributor

@vishakhanihore vishakhanihore commented Aug 29, 2019

Fixes #3395

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vishakhanihore
Copy link
Contributor Author

@CosmicCoder96 @shreyanshdwivedi @kushthedude please check

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but make sure that you provide a screenshot always

@vishakhanihore
Copy link
Contributor Author

This looks fine but make sure that you provide a screenshot always

@mrsaicharan1 Actually I am still understanding the workflow, This issue seemed so trivial to make a PR. I will manage ss from next PR

@mrsaicharan1
Copy link
Member

mrsaicharan1 commented Aug 29, 2019 via email

@kushthedude kushthedude changed the title omise image optimisation fix: omise image optimisation Aug 29, 2019
@auto-label auto-label bot added the fix label Aug 29, 2019
@shreyanshdwivedi
Copy link
Member

@vishakhanihore please add a screenshot in this PR itself and update the PR description

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please help to provide good descriptions in future PRs. Merging this.

@mariobehling mariobehling merged commit 5ca6f29 into fossasia:development Aug 30, 2019
@vishakhanihore
Copy link
Contributor Author

Thanks. Please help to provide good descriptions in future PRs. Merging this.

Sure sir, I will take care from next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Order Form: Optimise Omise Icon for Proper UI

6 participants