-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: omise image optimisation #3491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@CosmicCoder96 @shreyanshdwivedi @kushthedude please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine but make sure that you provide a screenshot always
@mrsaicharan1 Actually I am still understanding the workflow, This issue seemed so trivial to make a PR. I will manage ss from next PR |
That’s fine but update the description here with a screenshot for later
reference.
…On Thu, 29 Aug 2019 at 11:00 PM, vishakhanihore ***@***.***> wrote:
This looks fine but make sure that you provide a screenshot always
@mrsaicharan1 <https://github.com/mrsaicharan1> Actually I am still
understanding the workflow, This issue seemed so trivial to make a PR. I
will manage ss from next PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3491?email_source=notifications&email_token=AGAHUW376VJY2NXD77N7XX3QHABTNA5CNFSM4IR3ZDP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PHQ6A#issuecomment-526284920>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGAHUW7J3MUILS6UGTF2V4TQHABTNANCNFSM4IR3ZDPQ>
.
|
@vishakhanihore please add a screenshot in this PR itself and update the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please help to provide good descriptions in future PRs. Merging this.
Sure sir, I will take care from next time. |
Fixes #3395
Short description of what this resolves:
Changes proposed in this pull request:
Checklist
development
branch.