feat: PayPal env routing based on settings #3479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uds5501 @shreyanshdwivedi @CosmicCoder96 I've checked in this locally and can confirm that it hits the sanbox API for test mode and live API for live mode. Please do confirm this. |
abhinavk96
suggested changes
Aug 27, 2019
uds5501
suggested changes
Aug 27, 2019
mrsaicharan1
force-pushed
the
paypal-env
branch
from
ae8e916 to
ba74acb
Compare
mrsaicharan1
requested review from
abhinavk96,
kushthedude,
shreyanshdwivedi and
uds5501
kushthedude
previously approved these changes
Aug 29, 2019
uds5501
previously approved these changes
Aug 29, 2019
abhinavk96
approved these changes
Aug 29, 2019
abhinavk96
suggested changes
Aug 29, 2019
mrsaicharan1
force-pushed
the
paypal-env
branch
from
0aea579 to
5f78d76
Compare
mrsaicharan1
force-pushed
the
paypal-env
branch
from
5f78d76 to
2f09717
Compare
|
@CosmicCoder96 The paypal button requires the environment parameter to be |
abhinavk96
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3413
Short description of what this resolves:
Environment is being forced to a live environment without any param specified. TO properly route the API hit to sanbox/live, settings value is being passed.