Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 23, 2019

Fixes #3472

Short description of what this resolves:

The pagination/searching/sorting in event invoice table in billing info isn't working

Changes proposed in this pull request:

  • change searching to status attribute as there is no other searchable attribute
  • add sort options to status and amount
  • fix pagination by passing correct data in the list template

eventInvoice-2019-08-30_221605

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a GIF which shows pagination & sorting? Thanks!

@shreyanshdwivedi
Copy link
Member Author

@kushthedude @uds5501 @Mrsaicharan actually I'm traveling, so can you guys please pull the changes and review on your local. It'll be really helpful.
Thanks

@shreyanshdwivedi
Copy link
Member Author

@uds5501 @mrsaicharan1 @kushthedude I've added a gif for reference in the PR description. Please have a look

@abhinavk96 abhinavk96 merged commit 42b5bcc into fossasia:development Aug 31, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the invoiceTable branch August 31, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pagination/searching/sorting doesn't work in billing invoice table

5 participants