Skip to content

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Aug 22, 2019

Fixes #3464

Short description of what this resolves:

Due to computed properties which were named incorrectly, the alipay workflow was buggy. Now, it functions as expected.

Changes proposed in this pull request:

  • Fixed naming conventions for controller actions to make it compatible with server schema

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@mrsaicharan1
Copy link
Member Author

@uds5501 @shreyanshdwivedi @kushthedude I can confirm that the workflow is fixed with this. Tested properly.

Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the keys match with the ones at server now. It should work after this change.

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kushthedude kushthedude merged commit f87d084 into fossasia:development Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alipay naming convention bugs

4 participants