Skip to content

fix: uses refreshModel to refresh session table after an action #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

fix: uses refreshModel to refresh session table after an action #3448

merged 1 commit into from
Aug 20, 2019

Conversation

@shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 20, 2019 •
edited
Loading

Fixes #3449

Short description of what this resolves:

Sometimes, while viewing/editing/deleting a session, unexpected entries are passed as params. Fix it using extraRecords

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 20, 2019
kushthedude
kushthedude previously approved these changes Aug 20, 2019
View reviewed changes
@shreyanshdwivedi shreyanshdwivedi force-pushed the useExtraRecords branch 2 times, most recently from 085ca23 to 97ce593 Compare August 20, 2019 09:06
@shreyanshdwivedi shreyanshdwivedi changed the title fix: view/edit/delete sometimes pass unexpected values in session table fix: uses refreshModel to refresh session table after an action Aug 20, 2019
kushthedude
kushthedude previously approved these changes Aug 20, 2019
View reviewed changes
uds5501
uds5501 approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local.
Actions, Searching, Sorting and Pagination are working as expected.

mrsaicharan1
mrsaicharan1 reviewed Aug 20, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally ✔️

@kushthedude kushthedude merged commit e568a3b into fossasia:development Aug 20, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the useExtraRecords branch August 20, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce refreshModel to the session table

4 participants

@shreyanshdwivedi @uds5501 @mrsaicharan1 @kushthedude