Skip to content

Conversation

@Anupam-dagar
Copy link
Member

Fixes: #3122

Short description of what this resolves:
Currently there is no option to hide map in sidebar

Changes proposed in this pull request:
Add a button which toggles map visibility for mobile views.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshots

61171978-591c0300-a59c-11e9-8082-2bc465a5a3d2

61171977-58836c80-a59c-11e9-9b9c-12fbce338a4b

61171976-58836c80-a59c-11e9-9282-e6c14ba93ec0

@auto-label auto-label bot added the feature label Aug 19, 2019
@Anupam-dagar
Copy link
Member Author

@uds5501 I have imported get and used it too. Can you see why travis is failing?

@fossasia fossasia deleted a comment Aug 20, 2019
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anupam-dagar Please check if this breaks any functionality related to the actions you have refactored(es5->es6)

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on deployment and local, working as expected

Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on netlify deployment, maps are working as expected.

@abhinavk96 abhinavk96 merged commit f58911e into fossasia:development Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements in Browse Events Section

6 participants