Skip to content

fix: notify services in files #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 26, 2019
Merged

fix: notify services in files #3438

merged 11 commits into from
Aug 26, 2019

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Aug 18, 2019 •
edited
Loading

refers: #3437

@auto-label auto-label bot added the fix label Aug 18, 2019
@kushthedude
Copy link
Member Author

@CosmicCoder96 Please have a look here

abhinavk96
abhinavk96 reviewed Aug 18, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does adding id do, can you add a link to the docs

@kushthedude
Copy link
Member Author

https://github.com/adopted-ember-addons/ember-notify/blob/master/README.md

@kushthedude kushthedude requested a review from abhinavk96 August 19, 2019 06:53
abhinavk96
abhinavk96 suggested changes Aug 19, 2019
View reviewed changes
@fossasia fossasia deleted a comment Aug 20, 2019
@kushthedude
Copy link
Member Author

@CosmicCoder96 Please REview

@fossasia fossasia deleted a comment Aug 21, 2019
@fossasia fossasia deleted a comment Aug 21, 2019
@fossasia fossasia deleted a comment Aug 22, 2019
@fossasia fossasia deleted a comment Aug 22, 2019
@kushthedude
Copy link
Member Author

@shreyanshdwivedi @uds5501 @mrsaicharan1 please review

@abhinavk96 abhinavk96 merged commit 6a563e2 into fossasia:development Aug 26, 2019
@kushthedude kushthedude deleted the 98 branch September 16, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

@uds5501 uds5501 Awaiting requested review from uds5501

1 more reviewer

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kushthedude @abhinavk96