fix: event settings visible to admin and owner only #3432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyanshdwivedi
force-pushed
the
ownerSettings
branch
from
1127f08 to
9aef923
Compare
shreyanshdwivedi
requested review from
abhinavk96,
kushthedude,
mrsaicharan1 and
uds5501
kushthedude
reviewed
Aug 17, 2019
abhinavk96
suggested changes
Aug 18, 2019
shreyanshdwivedi
force-pushed
the
ownerSettings
branch
from
2d02aed to
aa26f60
Compare
Anupam-dagar
previously approved these changes
Aug 18, 2019
kushthedude
previously approved these changes
Aug 20, 2019
|
@CosmicCoder96 @mrsaicharan1 please review |
mrsaicharan1
suggested changes
Aug 20, 2019
shreyanshdwivedi
dismissed stale reviews from kushthedude, Anupam-dagar, and uds5501
via
f499fa4
shreyanshdwivedi
force-pushed
the
ownerSettings
branch
from
60d47a9 to
f499fa4
Compare
shreyanshdwivedi
force-pushed
the
ownerSettings
branch
from
f499fa4 to
b8ae561
Compare
mrsaicharan1
approved these changes
Aug 20, 2019
uds5501
approved these changes
Aug 21, 2019
kushthedude
approved these changes
Aug 21, 2019
|
@CosmicCoder96 please reveiew |
|
@CosmicCoder96 please review this. |
abhinavk96
suggested changes
Aug 27, 2019
| return this.l10n.t('Settings'); | ||
| }, | ||
| beforeModel() { | ||
| let { currentUser } = this.authManager; |
There was a problem hiding this comment.
how can this.authManager be currentUser?
There was a problem hiding this comment.
This is equivalent to let currentUser = this.authManager.currentUser
abhinavk96
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3354
Short description of what this resolves:
Currently, Event Role of every kind is able to see the following settings which should not be the case
Changes proposed in this pull request:
Settingsas an option only to admin or ownerSettings, redirect them to event.viewChecklist
developmentbranch.