Skip to content

fix: tickets fetched at each step of wizard #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2019
Merged

fix: tickets fetched at each step of wizard #3410

merged 4 commits into from
Aug 16, 2019

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 14, 2019

Fixes #3409

Changes proposed in this pull request:

  • add 'tickets' property to be fetched if not present

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 14, 2019
kushthedude
kushthedude previously approved these changes Aug 14, 2019
View reviewed changes
mrsaicharan1
mrsaicharan1 previously approved these changes Aug 14, 2019
View reviewed changes
abhinavk96
abhinavk96 suggested changes Aug 14, 2019
View reviewed changes
@uds5501
Copy link
Contributor Author

uds5501 commented Aug 16, 2019

@shreyanshdwivedi @mrsaicharan1 @CosmicCoder96 @kushthedude Please review this

@uds5501
Copy link
Contributor Author

uds5501 commented Aug 16, 2019

@kushthedude Please merge this

@abhinavk96 abhinavk96 merged commit 8fa3060 into fossasia:development Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

4 more reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@prateekj117 prateekj117 prateekj117 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tickets are required for publishing event error even when tickets are present

6 participants

@uds5501 @abhinavk96 @mrsaicharan1 @shreyanshdwivedi @prateekj117 @kushthedude