Skip to content

feat: link invoices to respective pages #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2019
Merged

feat: link invoices to respective pages #3402

merged 4 commits into from
Aug 14, 2019

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 13, 2019 •
edited
Loading

Fixes #3401

Changes proposed in this pull request:

  • Add action column in invoice table

bbd72f95-6dc5-44c5-b663-9e9900524e97

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Aug 13, 2019
@uds5501 uds5501 requested a review from mrsaicharan1 August 13, 2019 18:44
@mrsaicharan1
Copy link
Member

@uds5501 Just add a screenshot so that we can come back to this if we need it!

@uds5501
Copy link
Contributor Author

uds5501 commented Aug 14, 2019

@mrsaicharan1 Added the screenshot, please check.

mrsaicharan1
mrsaicharan1 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll speed up with the payments module and connect the workflow now as this was needed for it

shreyanshdwivedi
shreyanshdwivedi approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shreyanshdwivedi shreyanshdwivedi merged commit e7b88e1 into fossasia:development Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

3 more reviewers

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add links to view appropriate invoice pages in billing invoice table

4 participants

@uds5501 @mrsaicharan1 @shreyanshdwivedi @kushthedude