Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 13, 2019

Fixes #3393

Short description of what this resolves:

Event invoices aren't visible for all filter and there are few places to refactor

Changes proposed in this pull request:

  • fix column fetch for all filter
  • changed id to identifier and Name to Event Name
  • display amount alongwith currency

Screenshot_2019-08-13 All Invoices Billing Info Account Open Event

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also replace the invoicePdfUrl with the cell-link component, please? This would help us in invoice downloads.

@mrsaicharan1
Copy link
Member

Other than that, these enhancements and the fix looks fine

@shreyanshdwivedi
Copy link
Member Author

@mrsaicharan1 current server-side implementation to download invoice pdf is to be implemented.
I'll open a separate PR to add download pdf logic once it is implemented. Till then, I think we should move forward with this PR as it is more of an urgent fix to move forward for payment implementation

@fossasia fossasia deleted a comment Aug 14, 2019
@uds5501 uds5501 merged commit b83ce2c into fossasia:development Aug 14, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the eventInvoiceTable branch August 20, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event invoices not visible on being fetched correctly from server

4 participants