Skip to content

fix: add google re-captcha keys in setting model #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2019
Merged

fix: add google re-captcha keys in setting model #3387

merged 2 commits into from
Aug 13, 2019

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 13, 2019

Fixes #3386

Short description of what this resolves:

Adds re-captcha attributes to settings model

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 13, 2019
@uds5501 uds5501 requested review from kushthedude, mrsaicharan1 and shreyanshdwivedi and removed request for kushthedude August 13, 2019 07:44
kushthedude
kushthedude suggested changes Aug 13, 2019
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am well aware I added fields for reCAPTCHA in #3182, IDK which PR removed them and why.
@uds5501 Please refactor as it was done in #3182

@uds5501
Copy link
Contributor Author

uds5501 commented Aug 13, 2019

@kushthedude Refactored accordingly. Please check.

@uds5501 uds5501 requested a review from kushthedude August 13, 2019 09:24
@abhinavk96 abhinavk96 merged commit bdf274c into fossasia:development Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

3 more reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Google ReCaptcha Config Not Working

4 participants

@uds5501 @abhinavk96 @mrsaicharan1 @kushthedude