fix: resolve whack-a-mole behavior of time/date pickers & add validations to date-time #3383
Conversation
|
Also #2366 |
abhinavk96
changed the title
| // break; | ||
| // case 'end': | ||
| // defaultOptions.startCalendar = this.$().closest('.fields').find('.ui.calendar.time.picker'); | ||
| // break; |
There was a problem hiding this comment.
@CosmicCoder96 Remove the comments, Else tested every widget works well 🎉
There was a problem hiding this comment.
leaving these comments.. because someday we might want the time validation to change it's values according to its start counterpart, removed it for now because jquery ui calendar does not compare date while matching time fields, which sort of broke the UI.
Not reproducible on my local, Any specific steps? |
|
@kushthedude just edit the time and date while creating the discount code. You'll see it |
|
@shreyanshdwivedi @kushthedude The behavior shreyansh noted might be for some discount codes who previously had a null value. I can't recreate it while creating new ones or existing valid ones. Though I did was able to recreate that when I forced a false value for the start time inside DB. |
you mean edit using backspace? |
|
@CosmicCoder96 there was a weird behavior. When I followed links to create discount code and edited it, I was able to reproduce it. |
|
@shreyanshdwivedi Caught the source, thanks for the review 👍 fixed now. |
| }); | ||
| let currentDiscountCode = model.discountCode; | ||
| let event = this.modelFor('events.view'); | ||
| currentDiscountCode.set('validFrom', moment().toISOString()); |
There was a problem hiding this comment.
this was the problem 😈 converting it to string made it invalid to moment js computations.
@shreyanshdwivedi @kushthedude
4 participants
Fixes #3020
Fixes #3382
Fixes #2077
Fixes #2366
Fixes #2972