Skip to content

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 10, 2019

Fixes #3320

Changes proposed in this pull request:

  • Add PayTM credentials in settings model.
  • Add validations for new fields in the project.
  • Add fields following other payment gateways

Screenshot from 2019-08-10 13-28-37

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Aug 10, 2019
@uds5501 uds5501 requested review from abhinavk96, kushthedude, mrsaicharan1 and shreyanshdwivedi and removed request for mrsaicharan1 August 10, 2019 08:00
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501 So just for clarification, we're trying to enable scenarios where paytm can be disabled and keys are retained. Hope that helps! I've made the changes on the server too. So you can check it out.

@uds5501 uds5501 force-pushed the paytm-admin-settings branch from 1ad00b5 to 1fbc6c5 Compare August 10, 2019 09:57
@uds5501
Copy link
Contributor Author

uds5501 commented Aug 10, 2019

@kushthedude @mrsaicharan1 took care of these in the current iteration, please check

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding DO-NOT-MERGE until the server one is merged

@uds5501
Copy link
Contributor Author

uds5501 commented Aug 10, 2019

The server PR : fossasia/open-event-server#6249 has been merged.
@mrsaicharan1 please review and merge

@abhinavk96 abhinavk96 merged commit dadc0c7 into fossasia:development Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addition of PayTM keys in payment gateways

5 participants