Skip to content

Conversation

shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 7, 2019

Fixes #3364

Changes proposed in this pull request:

  • Adds stripe test keys to the payment-gateway-form

Test Keys
Screenshot_2019-08-08 Payment Gateway Settings Administration Open Event

Live Keys
Screenshot_2019-08-08 Payment Gateway Settings Administration Open Event(1)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shreyanshdwivedi shreyanshdwivedi changed the title enh: add stripe test keys to admin payment-form enh: add stripe test keys to admin payment-gateway-form Aug 7, 2019
@shreyanshdwivedi
Copy link
Member Author

@kushthedude @uds5501 @mrsaicharan1 @CosmicCoder96 please review

@kushthedude
Copy link
Member

@shreyanshdwivedi Rather than computed property, Cant we use a boolean as done for Paypal Mode ?

@shreyanshdwivedi
Copy link
Member Author

@kushthedude the server issue mentioned in the issue of this PR asked that we should use stripe test keys if the project is in debug environment. So I used computed property rather than a new variable stripeMode.

@fossasia fossasia deleted a comment Aug 8, 2019
@kushthedude kushthedude merged commit b308cda into fossasia:development Aug 8, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the stripeTest branch August 20, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add stripe test key fields to payment-gateway-form

4 participants