Skip to content

fix: profile picture link to null when removed #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2019
Merged

fix: profile picture link to null when removed #3361

merged 2 commits into from
Aug 9, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Aug 5, 2019 •
edited
Loading

profile

Fixes #3360

Short description of what this resolves:

Fixes profile picture removal

Changes proposed in this pull request:

  • Update avatarUrl to None on the model level when the picture gets deleted.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 5, 2019
@mrsaicharan1 mrsaicharan1 changed the title fix: profile picture removal fix fix: profile picture patch when removed Aug 6, 2019
@mrsaicharan1
Copy link
Member Author

I’m attempting a patch request through the frontend to update the avatar_url. This gives me a 415 error but it works when I use an API client. What might be the problem? @cosmiccoder96 @uds5501 @shreyanshdwivedi

abhinavk96
abhinavk96 suggested changes Aug 7, 2019
View reviewed changes
@mrsaicharan1 mrsaicharan1 force-pushed the fix-profile-pic branch 3 times, most recently from 24b903e to 1f0a58b Compare August 7, 2019 17:55
@mrsaicharan1 mrsaicharan1 mentioned this pull request Aug 8, 2019
Open
@mrsaicharan1 mrsaicharan1 changed the title fix: profile picture patch when removed fix: profile picture link to null when removed Aug 8, 2019
uds5501
uds5501 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local. Working fine

@abhinavk96 abhinavk96 merged commit 7cf7d45 into fossasia:development Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

3 more reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@uds5501 uds5501 uds5501 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Removing profile picture doesn't work

4 participants

@mrsaicharan1 @abhinavk96 @uds5501 @kushthedude