Skip to content

fix: change button positions and take out repeating buttons #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2019
Merged

fix: change button positions and take out repeating buttons #3344

merged 3 commits into from
Aug 1, 2019

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 1, 2019

Fixes #3343

image

Changes proposed in this pull request:

  • Remove duplicate buttons
  • Change button positions for Alipay, Omise

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 1, 2019
shreyanshdwivedi
shreyanshdwivedi approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushthedude kushthedude merged commit 5d7123c into fossasia:development Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

3 more reviewers

@pradeepgangwar pradeepgangwar pradeepgangwar approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Design bugs in pending order page

4 participants

@uds5501 @pradeepgangwar @shreyanshdwivedi @kushthedude