Skip to content

fix: allow decimal values for ticket prices #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2019
Merged

fix: allow decimal values for ticket prices #3341

merged 3 commits into from
Aug 1, 2019

Conversation

@mrsaicharan1
Copy link
Member

Fixes #3322

Short description of what this resolves:

Adds support for decimal prices for tickets.
Related server PR for price check:

Changes proposed in this pull request:

  • Changed validation rule

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 1, 2019
@mrsaicharan1 mrsaicharan1 mentioned this pull request Aug 1, 2019
Closed
@abhinavk96 abhinavk96 merged commit 48ab607 into fossasia:development Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to create paid ticket with price less than 1 (money unit)

2 participants

@mrsaicharan1 @abhinavk96