Skip to content

fix: use correct URL to download translations #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

fix: use correct URL to download translations #3336

merged 1 commit into from
Jul 31, 2019

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jul 31, 2019 •
edited by kushthedude
Loading

Fixes #3335

Short description of what this resolves:

Fixes the URL endpoint which is being hit when downloading the translations

Changes proposed in this pull request:

  • Restructure code according to ES6 style
  • Use /admin/content/translations/all/ to download files

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 31, 2019
mrsaicharan1
mrsaicharan1 approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked Locally. The module works

@kushthedude kushthedude merged commit 5228e0c into fossasia:development Jul 31, 2019
@kushthedude kushthedude mentioned this pull request Jul 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Admin Translations downloads error

5 participants

@uds5501 @abhinavk96 @mrsaicharan1 @shreyanshdwivedi @kushthedude