Skip to content

Conversation

@prateekj117
Copy link
Member

Fixes #3299

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Jul 30, 2019
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekj117 Can't you add this in the adapter file made by @CosmicCoder96, rather than making another adapter ?

Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make a PR, when it doesn't work, are these changes enough? Adding the adapter won't make it switch end-points.
It's a huge time waste for the reviewer, and bad practice to not test your own code at all.

@prateekj117
Copy link
Member Author

@CosmicCoder96 I still face the Url incorrect error. I think it's because the Request Method is Option instead of GET. I think it's a CORS policy error.

@abhinavk96 abhinavk96 merged commit 85cb5a3 into fossasia:development Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change endpoint for discount code and access code.

3 participants