Skip to content

feat: Implementation of review route for event invoice payment #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2019
Merged

feat: Implementation of review route for event invoice payment #3317

merged 3 commits into from
Aug 2, 2019

Conversation

@mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jul 29, 2019 •
edited
Loading

Fixes #3312

Screenshot 2019-07-31 at 8 46 30 PM

Short description of what this resolves:

This PR aids in reviewing the invoice before the payment. It includes billing info & related invoice details .

Changes proposed in this pull request:

  • Added review routes, controller & templates
  • Added corresponding billing info

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@mrsaicharan1 mrsaicharan1 force-pushed the review-invoice branch 4 times, most recently from 5277728 to 7216317 Compare July 31, 2019 15:18
@mrsaicharan1 mrsaicharan1 changed the title [WIP]feat: Implementation of review route for event invoice payment feat: Implementation of review route for event invoice payment Jul 31, 2019
@auto-label auto-label bot added the feature label Jul 31, 2019
@mrsaicharan1
Added review routes & corresponding billing info
0f4997c 
Fix Travis & add include id in URL

Added invoice info
pradeepgangwar
pradeepgangwar reviewed Aug 1, 2019
View reviewed changes
shreyanshdwivedi
shreyanshdwivedi approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As review route is completed, I'll start with the completed route for event invoices :)

@pradeepgangwar pradeepgangwar merged commit cf1aba3 into fossasia:development Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

3 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@pradeepgangwar pradeepgangwar pradeepgangwar approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement route for review-invoice(event-invoice)

4 participants

@mrsaicharan1 @uds5501 @pradeepgangwar @shreyanshdwivedi