Skip to content

fix: Restrict event save when information is insufficient #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2019
Merged

fix: Restrict event save when information is insufficient #3305

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecf413f
fix: restrict event saving if information is incomplete
uds5501 Aug 3, 2019
4202559
Merge branch 'development' into event-check-errors
mrsaicharan1 Aug 9, 2019
25a9633
Merge branch 'development' into event-check-errors
abhinavk96 Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 59 additions & 41 deletions app/mixins/event-wizard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,59 +59,76 @@ export default Mixin.create(MutableArray, CustomFormMixin, {
}
}
}
const numberOfTickets = data.tickets ? data.tickets.length : 0;
if (event.name && event.locationName && event.startsAtDate && event.endsAtDate && numberOfTickets > 0) {
await event.save();

await event.save();

for (const ticket of data.tickets ? data.tickets.toArray() : []) {
ticket.set('maxOrder', Math.min(ticket.get('maxOrder'), ticket.get('quantity')));
await ticket.save();
}
for (const ticket of data.tickets ? data.tickets.toArray() : []) {
ticket.set('maxOrder', Math.min(ticket.get('maxOrder'), ticket.get('quantity')));
await ticket.save();
}

for (const socialLink of data.socialLinks ? data.socialLinks.toArray() : []) {
await socialLink.save();
}
for (const socialLink of data.socialLinks ? data.socialLinks.toArray() : []) {
await socialLink.save();
}

if (data.copyright && data.copyright.get('licence')) {
await data.copyright.save();
}
if (data.copyright && data.copyright.get('licence')) {
await data.copyright.save();
}

if (data.tax && data.tax.get('name')) {
let tax = this.setRelationship(data.tax, event);
if (event.get('isTaxEnabled')) {
await tax.save();
} else {
await tax.destroyRecord();
if (data.tax && data.tax.get('name')) {
let tax = this.setRelationship(data.tax, event);
if (event.get('isTaxEnabled')) {
await tax.save();
} else {
await tax.destroyRecord();
}
}
}

if (data.stripeAuthorization && data.stripeAuthorization.get('stripeAuthCode')) {
let stripeAuthorization = this.setRelationship(data.stripeAuthorization, event);
if (event.get('canPayByStripe')) {
await stripeAuthorization.save();
} else {
await stripeAuthorization.destroyRecord();
if (data.stripeAuthorization && data.stripeAuthorization.get('stripeAuthCode')) {
let stripeAuthorization = this.setRelationship(data.stripeAuthorization, event);
if (event.get('canPayByStripe')) {
await stripeAuthorization.save();
} else {
await stripeAuthorization.destroyRecord();
}
}
}

const bulkPromises = [];
const bulkPromises = [];

for (const property of ['tracks', 'sessionTypes', 'microlocations', 'customForms']) {
const items = data[property];
for (const item of items ? items.toArray() : []) {
bulkPromises.push(event.get('isSessionsSpeakersEnabled') ? item.save() : item.destroyRecord());
for (const property of ['tracks', 'sessionTypes', 'microlocations', 'customForms']) {
const items = data[property];
for (const item of items ? items.toArray() : []) {
bulkPromises.push(event.get('isSessionsSpeakersEnabled') ? item.save() : item.destroyRecord());
}
}
}

for (const property of ['sponsors']) {
const items = data[property];
for (const item of items ? items.toArray() : []) {
bulkPromises.push(event.get('isSponsorsEnabled') ? item.save() : item.destroyRecord());
for (const property of ['sponsors']) {
const items = data[property];
for (const item of items ? items.toArray() : []) {
bulkPromises.push(event.get('isSponsorsEnabled') ? item.save() : item.destroyRecord());
}
}
}

await Promise.all(bulkPromises);
await Promise.all(bulkPromises);

return event;
return event;
} else {
let errorObject = { 'errors': [] };
if (event.name === undefined || event.name === '') {
errorObject.errors.push({ 'detail': 'Event name has not been provided' });
}
if (event.locationName === undefined || event.locationName === '') {
errorObject.errors.push({ 'detail': 'Location has not been provided' });
}
if (event.startsAtDate === undefined || event.endsAtDate === undefined) {
errorObject.errors.push({ 'detail': 'Dates have not been provided' });
}
if (numberOfTickets === 0) {
errorObject.errors.push({ 'detail': 'Tickets are required for publishing event' });
}
throw (errorObject);
}
},

/**
Expand All @@ -128,8 +145,9 @@ export default Mixin.create(MutableArray, CustomFormMixin, {
this.transitionToRoute(route, data.id);
})
.catch(e => {
console.error(e);
this.notify.error(this.l10n.t(e.errors[0].detail));
e.errors.forEach(error => {
this.notify.error(this.l10n.tVar(error.detail));
});
})
.finally(() => {
this.set('isLoading', false);
Expand Down