Skip to content

enh: Moving Order_Expiry_Time into Admin/Settings #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 14, 2019
Merged

enh: Moving Order_Expiry_Time into Admin/Settings #3283

merged 17 commits into from
Aug 14, 2019

Conversation

kushthedude
Copy link
Member

Fixes #3161

Short description of what this resolves:

  • Moved all the Order_Expiry_Time into Admin Dashboard

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kushthedude kushthedude requested review from abhinavk96, niranjan94 and uds5501 and removed request for niranjan94 July 15, 2019 07:04
@kushthedude kushthedude mentioned this pull request Jul 15, 2019
Closed
5 tasks
@kushthedude
Copy link
Member Author

@uds5501 @shreyanshdwivedi @CosmicCoder96 @mrsaicharan1 Please Review

@fossasia fossasia deleted a comment Jul 28, 2019
@fossasia fossasia deleted a comment Jul 30, 2019
@kushthedude
Copy link
Member Author

@shreyanshdwivedi @uds5501 @mrsaicharan1 Please Review

@kushthedude kushthedude requested review from mrsaicharan1, shreyanshdwivedi and uds5501 and removed request for uds5501 July 30, 2019 10:17
uds5501
uds5501 previously approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order Flow working as expected, marking LGTM

@fossasia fossasia deleted a comment Jul 30, 2019
abhinavk96
abhinavk96 suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3228 (comment)

@fossasia fossasia deleted a comment Aug 3, 2019
@fossasia fossasia deleted a comment Aug 9, 2019
@kushthedude kushthedude requested review from abhinavk96, mrsaicharan1, niranjan94 and shreyanshdwivedi and removed request for abhinavk96 August 13, 2019 09:22
@fossasia fossasia deleted a comment Aug 13, 2019
abhinavk96
abhinavk96 suggested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the conflicts

@kushthedude
Copy link
Member Author

@CosmicCoder96 Conflicts Resolved !

@kushthedude kushthedude requested a review from uds5501 August 13, 2019 19:20
@fossasia fossasia deleted a comment Aug 13, 2019
@kushthedude kushthedude requested a review from abhinavk96 August 13, 2019 20:09
@fossasia fossasia deleted a comment Aug 14, 2019
@fossasia fossasia deleted a comment Aug 14, 2019
@fossasia fossasia deleted a comment Aug 14, 2019
@kushthedude
Copy link
Member Author

@mrsaicharan1 Please REview

@fossasia fossasia deleted a comment Aug 14, 2019
@fossasia fossasia deleted a comment Aug 14, 2019
@kushthedude
Copy link
Member Author

@shreyanshdwivedi please review

@shreyanshdwivedi shreyanshdwivedi merged commit b0bcbf2 into fossasia:development Aug 14, 2019
@kushthedude kushthedude deleted the expiry branch November 8, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niranjan94 niranjan94 Awaiting requested review from niranjan94

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

3 more reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move registration time limit to admin settings and set standard to 15 minutes

4 participants

@kushthedude @abhinavk96 @uds5501 @shreyanshdwivedi