feat: Add checkbox to sidebar filters in explore route. #3263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Push any test commit, Let |
kushthedude
changed the title
abhinavk96
suggested changes
Jul 12, 2019
| {{#each dateRanges as |dateRange|}} | ||
| <div class="field"> | ||
| <div class="ui checkbox"> | ||
| <input type="checkbox" onChange={{action 'selectDateFilter' dateRange.key}} checked={{if (eq dateType dateRange.key) 'active'}}> |
Contributor
There was a problem hiding this comment.
use semantic-ui-ember checkbox.
| {{#each Category.subTopics as |subCategory|}} | ||
| <div class="field inner item"> | ||
| <div class="ui checkbox"> | ||
| <input type="checkbox" onChange={{action 'selectCategory' Category.name subCategory.slug}} checked={{if (eq sub_category subCategory.slug) 'active'}}> |
Contributor
There was a problem hiding this comment.
use semantic-ui-ember checkbox.
| {{#each model.eventTypes as |eventType|}} | ||
| <div class="field"> | ||
| <div class="ui checkbox"> | ||
| <input type="checkbox" onChange={{action 'selectEventType' eventType.name}} checked={{if (eq event_type eventType.name) 'active'}}> |
Contributor
There was a problem hiding this comment.
use semantic-ui-ember checkbox.
| <div class="grouped fields"> | ||
| <div class="field"> | ||
| <div class="ui checkbox"> | ||
| <input type="checkbox" onChange={{action 'selectTicketType' 'free'}} checked={{if (eq ticket_type 'free') true}}> |
Contributor
There was a problem hiding this comment.
use semantic-ui-ember checkbox.
| </div> | ||
| </div> | ||
| <div class="field"> | ||
| <div class="ui checkbox checkbox"> |
Contributor
There was a problem hiding this comment.
use semantic-ui-ember checkbox.
Member
Author
|
I have made the requested changes. |
kushthedude
suggested changes
Jul 14, 2019
| <div class="grouped fields"> | ||
| {{#each Category.subTopics as |subCategory|}} | ||
| <div class="field inner item"> | ||
| {{ui-checkbox label=subCategory.name class='toggle' checked=(if (eq sub_category subCategory.slug) 'active') onChange=(action 'selectCategory' Category.name subCategory.slug)}} |
Member
There was a problem hiding this comment.
Use checkbox rather than toggle
Anupam-dagar
force-pushed
the
sidebarfinal
branch
from
924d319 to
8bcc2ee
Compare
abhinavk96
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3098
Short description of what this resolves:
There are no checkboxes in the sidebar filter of explore route.
Changes proposed in this pull request:
Checklist
developmentbranch.Screenshots