Skip to content

fix: Date sort support + avoid null sorts comparison #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

fix: Date sort support + avoid null sorts comparison #3243

merged 1 commit into from
Jul 5, 2019

Conversation

@abhinavk96
Copy link
Contributor

@abhinavk96 abhinavk96 commented Jul 4, 2019

Fixes #3242

Short description of what this resolves:

  • initializes sorts beforehand to avoid making params accidentally null.
  • Adds date sort support for ember-tables.

@auto-label auto-label bot added the fix label Jul 4, 2019
@abhinavk96 abhinavk96 requested a review from niranjan94 July 4, 2019 23:28
@abhinavk96 abhinavk96 merged commit 8df2d0b into fossasia:development Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@niranjan94 niranjan94 niranjan94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ember tables: Manage event table date sort support

2 participants

@abhinavk96 @niranjan94