Skip to content

enh: Making company details optional in tax modal #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2019
Merged

enh: Making company details optional in tax modal #3237

merged 1 commit into from
Jul 4, 2019

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Jul 4, 2019 •
edited
Loading

Fixes #3236

Short description of what this resolves:

  • After removing Company Details Tickbox, We forgot to make these fields optional

ScreenShot :

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kushthedude
Copy link
Member Author

@shreyanshdwivedi @uds5501 @CosmicCoder96 Please Review

@niranjan94 niranjan94 merged commit 180bff8 into fossasia:development Jul 4, 2019
@kushthedude kushthedude deleted the 1 branch July 13, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@niranjan94 niranjan94 niranjan94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tax Modal : Make Company Details in Tax Modal optional

2 participants

@kushthedude @niranjan94