Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Jul 3, 2019

Reference - #3225
Server PR - fossasia/open-event-server#6131

Short description of what this resolves:

Recently, event owner role is added to server. This is a follow-up PR to ensure the changes are applied to FE too

Changes proposed in this pull request:

  • Adds owner to admin-statistics-user
  • Changes hasOrganizerInfo, organizerName, organizerDescription to -> hasOwnerInfo. ownerName, ownerDescription respectively in event model.
  • Adds owner relationship to event model
  • Adds isUserOwner and ownerEvents to user model.
  • Adds owner to event-role permissions
  • Make relevant changes to template to accomodate above mentioned changes

Manage Events
Screenshot_2019-07-03 Live Events Open Event

Event Owner Permissions
Screenshot_2019-07-03 Event Roles Permissions Administration Open Event

Admin Events
Screenshot_2019-07-03 Events Administration Open Event

Admin Dashboard
Screenshot_2019-07-03 Administration Open Event

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Jul 3, 2019
@kushthedude
Copy link
Member

@shreyanshdwivedi Make the changes in Admin/Dashboard too

@shreyanshdwivedi
Copy link
Member Author

@kushthedude which changes? I'll suggest you to pull the changes and check because I think I already implemented what you're suggesting. Please check if I left any place which needs refactor too.
Thank You

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple Roles not getting shown in Roles Column :

image
image

No Of Owners not getting rendered in Admin Dashboard :

image

@kushthedude
Copy link
Member

Permissions Panel needs updation too :

image

@shreyanshdwivedi
Copy link
Member Author

shreyanshdwivedi commented Jul 3, 2019

@kushthedude please refer to my screenshots for first issue. Multiple roles are getting rendered.
For other issues, I've already opened a server PR. Forgot to link it - fossasia/open-event-server#6131
This can be merged after server PR is merged

abhinavk96
abhinavk96 previously approved these changes Jul 3, 2019
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this urgently, as the server is already about to go in production, Send follow up PRs if there are bugs.

@kushthedude
Copy link
Member

@shreyanshdwivedi Great, so we can cover each and every refactor in various PRs to test it properly

@abhinavk96 abhinavk96 dismissed their stale review July 3, 2019 09:11

Make any changes, you want. Not going into production now.

@shreyanshdwivedi
Copy link
Member Author

@kushthedude @uds5501 @mrsaicharan1 please review

@shreyanshdwivedi
Copy link
Member Author

@uds5501 @kushthedude @CosmicCoder96 the server PR is merged. This PR is ready to be reviewed and can be merged

@abhinavk96 abhinavk96 merged commit eb06b4e into fossasia:development Jul 4, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the ownerRole branch August 20, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants