Skip to content

Test: Adding Tests for Admin System Forms #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2019
Merged

Test: Adding Tests for Admin System Forms #3221

merged 2 commits into from
Jul 1, 2019

Conversation

@kushthedude
Copy link
Member

Fixes #3216

Short description of what this resolves:

  • Adding Test Files for components in Admin System Forms

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

mrsaicharan1
mrsaicharan1 approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kushthedude kushthedude merged commit 91265da into fossasia:development Jul 1, 2019
@kushthedude kushthedude deleted the testing1 branch July 13, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

2 more reviewers

@niranjan94 niranjan94 niranjan94 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test: Write Tests for Admin System Forms

3 participants

@kushthedude @niranjan94 @mrsaicharan1