Skip to content

fix: Adding Speaker Image in Session Accordion #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2019
Merged

fix: Adding Speaker Image in Session Accordion #3220

merged 2 commits into from
Jul 1, 2019

Conversation

@kushthedude
Copy link
Member

Fixes #3219

Short description of what this resolves:

  • Adding Speaker URL rightly

Screenshot

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jun 30, 2019
@niranjan94 niranjan94 requested a review from abhinavk96 July 1, 2019 03:42
@kushthedude
Copy link
Member Author

@uds5501 @mrsaicharan1 Please REview

@kushthedude kushthedude merged commit 616e998 into fossasia:development Jul 1, 2019
@kushthedude kushthedude deleted the session branch July 13, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

4 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@Anupam-dagar Anupam-dagar Anupam-dagar approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@prateekj117 prateekj117 prateekj117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Public Event Page: Speaker Image not visible in Session Accordion

5 participants

@kushthedude @uds5501 @Anupam-dagar @shreyanshdwivedi @prateekj117