enh: changing status route to invoice #3213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screen shot of results after the changes : |
|
@mrsaicharan1 @shreyanshdwivedi @kushthedude please review |
niranjan94
suggested changes
Jun 28, 2019
abhinavk96
approved these changes
Jun 28, 2019
app/templates/admin/sales.hbs
Outdated
| {{t 'Fees'}} | ||
| {{/link-to}} | ||
| {{#link-to 'admin.sales.status' class='item'}} | ||
| {{#link-to 'admin.sales.invoice' class='item'}} |
There was a problem hiding this comment.
shouldn't it be invoices too? I guess the route name and file names must be same.
There was a problem hiding this comment.
@Anupam-dagar you are right. pushing the fix.
uds5501
force-pushed
the
status-to-invoice
branch
from
6247e6c to
7d47ce4
Compare
|
@niranjan94 please review this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3212
Short description of what this resolves:
Renames sales/status route to sales/invoice
Checklist
developmentbranch.