Skip to content

fix: mobile view profile changes to account #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2019
Merged

fix: mobile view profile changes to account #3210

merged 2 commits into from
Jun 29, 2019

Conversation

@Hrtkk
Copy link
Contributor

@Hrtkk Hrtkk commented Jun 27, 2019

Fixes #

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@mrsaicharan1
Copy link
Member

mrsaicharan1 commented Jun 27, 2019 •
edited
Loading

@Eagle732 Please open an appropriate issue followed by a picture which depicts what needs to be changed. Link it to this PR if there is an issue related to this. Thanks!

Anupam-dagar
Anupam-dagar reviewed Jun 27, 2019
View reviewed changes
Copy link
Member

@Anupam-dagar Anupam-dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the issue number in front of Fixes so that the relevant can be automatically closed after the PR is merged. Since it is a frontend change, it will great to add screenshot or GIF for a better review.

Anupam-dagar
Anupam-dagar approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@Anupam-dagar Anupam-dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than not following the guidelines, the changes LGTM.

kushthedude
kushthedude approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read FOSSASIA's Best Practices and Guidelines, Else LGTM

@niranjan94 niranjan94 merged commit 9918d77 into fossasia:development Jun 29, 2019
@uds5501 uds5501 mentioned this pull request Jun 30, 2019
Closed
@kushthedude kushthedude changed the title mobile view profile changes to account fix: mobile view profile changes to account Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@Anupam-dagar Anupam-dagar Anupam-dagar approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@prateekj117 prateekj117 prateekj117 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Hrtkk @mrsaicharan1 @uds5501 @Anupam-dagar @shreyanshdwivedi @prateekj117 @kushthedude @niranjan94