feat:Adds quantity support & prevents zero valued donation tickets

[mrsaicharan1]

Fixes #3184

When organizer tries to adds tickets worth of 0 value

When the ticket buyer tries to add zero valued donation tickets

Short description of what this resolves:

Does not allow donation tickets worth of 0 value to be purchased & adds quantity support

Changes proposed in this pull request:

• Added quantity support for donation tickets
• Removed duplicate code segment
• Added check to prevent donation tickets whose value is 0

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[mrsaicharan1]

@CosmicCoder96 @niranjan94 @uds5501 @shreyanshdwivedi I was able to add support for quantity in donation tickets.
On the other hand, I've added validation checks and added a min & max attribute to the ticket price . But it's still allowing me to order with 0 price. Could you help me out here?

[kushthedude]

@CosmicCoder96 @niranjan94 @uds5501 @shreyanshdwivedi I was able to add support for quantity in donation tickets.
On the other hand, I've added validation checks and added a min & max attribute to the ticket price . But it's still allowing me to order with 0 price. Could you help me out here?

Add a server validation for minimum number of tickets . @mrsaicharan1

[mrsaicharan1]

@CosmicCoder96 @niranjan94 @uds5501 @shreyanshdwivedi I was able to add support for quantity in donation tickets.
On the other hand, I've added validation checks and added a min & max attribute to the ticket price . But it's still allowing me to order with 0 price. Could you help me out here?

Add a server validation for minimum number of tickets . @mrsaicharan1

Yeah I figured that part out but now suppose I want to check if the order contains a donation ticket with amount given as zero and the following data is being sent to create an order, won't be able to check it as there is no ticket info going through.

{
  "data": {
    "attributes": {
      "payment-mode": "paypal",
      "country": "India",
      "status": "pending",
      "amount": "10",
      "order-notes": "example"
    },
    "type": "order",
    "relationships": {
      "attendees": {
        "data": [
          {
            "id": "1",
            "type": "attendee"
          }
        ]
      },
      "event": {
        "data": {
          "id": "1",
          "type": "event"
        }
      }
    }
  }
}

[mrsaicharan1]

I've added a computed function which would disable the order now button if the ticket price for donations is 0. But there seems to be some error @shreyanshdwivedi @uds5501

[mrsaicharan1]

I've changed the condition such that the donation price should be greater than the minimum price set for it by the organizer.

[mrsaicharan1]

@mariobehling @CosmicCoder96 Please have a look at this.

[uds5501]

LGTM

[mrsaicharan1]

@CosmicCoder96 Updated with the min/max validation rule.Please review.

[pradeepgangwar]

LGTM

[mrsaicharan1]

In the validation rule,

window.$.fn.form.settings.rules.checkMaxMin = () => {
	      let { tickets } = this.tickets;
	      for (let ticket of tickets) {
	        if ((ticket.minPrice <= ticket.maxPrice) && (ticket.minPrice > 0) && (ticket.maxPrice > 0)) {
	          return true;
	        }
	      }
	      return false;
	    };

when I use object structuring/destructuring, i.e let { tickets } = this.tickets; I get
checkMaxMin — basic-details-step.js:124TypeError: undefined is not an object (evaluating 'tickets[Symbol.iterator]') when I try to enter max/min values while creating new donation tickets

But when I just use let tickets = this.tickets; , It works perfectly.

[kushthedude]

@mrsaicharan1 This PR needs more modification see this images :

• Unable to add Donation Tickets, Getting this error :
  

• When ever a donation ticket is added , Show payment options , It can happen if a event only has Free and Donation Tickets .

[kushthedude]

@mrsaicharan1 The Ticket Input is still broken in Orientation and UI:

[niranjan94]

when I use object structuring/destructuring, i.e let { tickets } = this.tickets

[niranjan94]

Incorrect.

Should be

let { tickets } = this;

But then, why do you even need to store it in a variable ? You can directly use this.tickets everywhere right ?

[mrsaicharan1]

@niranjan94 Yes, you're right. Will use it.