Skip to content

Conversation

@kushthedude
Copy link
Member

Fixes #3176

Short description of what this resolves:

  • Made gender as a dropdown in Attendee Form

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kushthedude
Copy link
Member Author

@shreyanshdwivedi @uds5501 @prateekj117 Please Review

@kushthedude
Copy link
Member Author

@niranjan94 @CosmicCoder96 Please Review

Anupam-dagar
Anupam-dagar previously approved these changes Jun 24, 2019
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushthedude LGTM, but now you will have to write a migration file too, which takes care of all the records which were already created. Send a PR on the server for that.

@kushthedude
Copy link
Member Author

@kushthedude LGTM, but now you will have to write a migration file too, which takes care of all the records which were already created. Send a PR on the server for that.

@CosmicCoder96 I don't think a migration file is needed, As in this PR https://github.com/fossasia/open-event-server/pull/5909/files when the gender field type was changes it was changed in whole custom_form schema, There we didn't explicitly define the relation of gender with any object like Speaker or Attendee.

@abhinavk96
Copy link
Contributor

abhinavk96 commented Jun 25, 2019 via email

prateekj117
prateekj117 previously approved these changes Jun 27, 2019
Copy link
Member

@prateekj117 prateekj117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But this must be merged after the migration file on server is merged

@kushthedude
Copy link
Member Author

@CosmicCoder96 Server PR is merged fossasia/open-event-server#6117

@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 Please REview

@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 Please REview

@abhinavk96 abhinavk96 merged commit 0e79f6b into fossasia:development Jul 6, 2019
@kushthedude kushthedude deleted the drop branch July 6, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attendee Form: Make gender field a dropdown instead of textbox

6 participants