feat: Add link "Show more calls for speakers" below section on start page. #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsaicharan1
previously approved these changes
Jun 23, 2019
kushthedude
previously approved these changes
Jun 23, 2019
shreyanshdwivedi
previously approved these changes
Jun 23, 2019
There was a problem hiding this comment.
LGTM 👍
But can be merged once #3144 gets merged. Putting DO-NOT-MERGE label therefore
abhinavk96
suggested changes
Jul 4, 2019
app/templates/index.hbs
Outdated
| <div class="ui hidden divider"></div> | ||
| <div class="ui centered grid"> | ||
| <div class="row"> | ||
| {{#link-to "explore" (query-params cfs=true) class='ui blue button'}}{{t 'Show more Call for Speakers'}}{{/link-to}} |
There was a problem hiding this comment.
"Show more calls for speakers"
Anupam-dagar
dismissed stale reviews from prateekj117, shreyanshdwivedi, kushthedude, mrsaicharan1, and uds5501
via
d280dfa
|
I have made the requested changes. Since #3144 is merged, this can be merged now. |
kushthedude
approved these changes
Jul 6, 2019
Anupam-dagar
changed the title
abhinavk96
approved these changes
Jul 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3100
This PR has a dependency on #3144.
This PR can be merged but it will be functional only after #3144 gets merged.
Short description of what this resolves:
This adds a hyperlink on home page call for speakers to list all call for speakers with call for speakers
Open.Changes proposed in this pull request:
link toin frontend with query paramcfsset totrue.Checklist
developmentbranch.Screenshots