Skip to content

fix: add placed orders in tickets overview #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pradeepgangwar merged 3 commits into from
Jun 17, 2019
Merged

fix: add placed orders in tickets overview #3151

pradeepgangwar merged 3 commits into from
Jun 17, 2019

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 17, 2019 •
edited
Loading

Fixes #3070

Changes proposed in this pull request:

  • Modify component to minimize template level logic

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Event/Tickets :

image

Event-dashboard :

Screenshot from 2019-06-17 11-12-58

@auto-label auto-label bot added the fix label Jun 17, 2019
pradeepgangwar
pradeepgangwar previously approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@pradeepgangwar pradeepgangwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradeepgangwar
Copy link
Member

pradeepgangwar commented Jun 17, 2019 •
edited
Loading

Please fix the integration tests. Before pushing your PR try to run the integration tests locally. Acceptance tests may fail locally but integration tests should pass locally.

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 17, 2019

@pradeepgangwar Yes, fixing them immediately.

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 17, 2019

@CosmicCoder96 @pradeepgangwar @mrsaicharan1 @shreyanshdwivedi please review

shreyanshdwivedi
shreyanshdwivedi approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pradeepgangwar pradeepgangwar merged commit 7cbf3fe into fossasia:development Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariobehling mariobehling mariobehling approved these changes

+2 more reviewers

@pradeepgangwar pradeepgangwar pradeepgangwar approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offline Tickets to show in sold tickets

4 participants

@uds5501 @pradeepgangwar @mariobehling @shreyanshdwivedi