feat: toggle filters in mobile devices #3137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjan94
suggested changes
Jun 13, 2019
| return getDateRanges.bind(this)(); | ||
| }), | ||
|
|
||
| showFiltersOnMobile: computed('device.isMobile', 'showFilters', function() { |
Contributor
Author
There was a problem hiding this comment.
actually had to change the logic because the filters weren't showing up on desktop.. Please review now? @niranjan94
uds5501
force-pushed
the
explore-browser-section
branch
from
6cb7da2 to
8a28670
Compare
niranjan94
suggested changes
Jun 14, 2019
app/components/explore/side-bar.js
Outdated
| }), | ||
|
|
||
| showFiltersOnMobile: computed('device.isMobile', 'showFilters', function() { | ||
| return ((this.device.isMobile && this.showFilters) || !this.device.isMobile); |
Member
There was a problem hiding this comment.
@uds5501 could this logic be simplified into
!this.device.isMobile || this.showFilters
uds5501
changed the title
uds5501
changed the title
kushthedude
suggested changes
Jun 14, 2019
Member
kushthedude
left a comment
kushthedude
left a comment
There was a problem hiding this comment.
@uds5501 A toggle switch would be better than a button
Contributor
Author
|
@kushthedude I think I tried following EventBrite UI as closely as possible without disturbing the basic UI of the code, they went with button so I think it's best we go with button too 😅 . Of course, I am prepared to make the change if the mentors agree to that. @CosmicCoder96 @niranjan94 @SaptakS @pradeepgangwar |
abhinavk96
approved these changes
Jun 15, 2019
kushthedude
approved these changes
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3136
Changes proposed in this pull request:
Checklist
developmentbranch.Two mobile views of the implementation, with and without the filters
Without :
With :