Skip to content

enh: rename non-admin settings routes to account #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2019
Merged

enh: rename non-admin settings routes to account #3134

merged 3 commits into from
Jun 14, 2019

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 12, 2019 •
edited
Loading

Fixes #3119

Short description of what this resolves:

Rename non-admin routes to say account instead of setting

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@uds5501 uds5501 changed the title enh: rename non-admin settings routes to account [wip]enh: rename non-admin settings routes to account Jun 12, 2019
@uds5501 uds5501 changed the title [wip]enh: rename non-admin settings routes to account enh: rename non-admin settings routes to account Jun 12, 2019
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 12, 2019

@shreyanshdwivedi @kushthedude @CosmicCoder96 please review

pradeepgangwar
pradeepgangwar reviewed Jun 14, 2019
View reviewed changes
Copy link
Member

@pradeepgangwar pradeepgangwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!
@uds5501 Email preferences is not working. Was it like that before too?

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 14, 2019

@pradeepgangwar Yes. Just verified in old dev branch. It's like that only

@mariobehling mariobehling merged commit c635c9f into fossasia:development Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariobehling mariobehling mariobehling approved these changes

+2 more reviewers

@pradeepgangwar pradeepgangwar pradeepgangwar left review comments

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename "Settings" to "Account"

4 participants

@uds5501 @mariobehling @abhinavk96 @pradeepgangwar