Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

Fixes #3043

Short description of what this resolves:

Session of the Speaker are not getting listed under Its Heading on Public Pages due to :

  • html-safe not a helper error

Changes proposed in this pull request:

  • removes html-safe helper
  • adds a condition to add a subheading Microlocation on speaker-item to increase the understanding.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jun 9, 2019
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyanshdwivedi The following solves the speaker tab issue too 🎉 , All the speakers are getting loaded on one go , just one improvement i could suggest ,Please remove the highlighting of session name and time , Its looking very weird on the public page
Screenshot 2019-06-09 at 11 06 40 AM

@shreyanshdwivedi
Copy link
Member Author

@kushthedude actually the highlighting of session name and time depends on track a user selects. You remember while creating an event we used to select track and color? That color is being used here. It signifies the track

kushthedude
kushthedude previously approved these changes Jun 9, 2019
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this #3075 is also solved except the dependancy issue ,Which i will see today if i could find any alternatives

ritikamotwani
ritikamotwani previously approved these changes Jun 10, 2019
@shreyanshdwivedi
Copy link
Member Author

@kushthedude @ritikamotwani I just made a small change on line 64 and force pushed. Lost your review. Please review again

uds5501
uds5501 previously approved these changes Jun 10, 2019
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

ritikamotwani
ritikamotwani previously approved these changes Jun 10, 2019
kushthedude
kushthedude previously approved these changes Jun 10, 2019
prateekj117
prateekj117 previously approved these changes Jun 10, 2019
{{/if}}
</p>
<div class="ui fluid padded" style={{-html-safe (concat "color: " session.track.fontColor "px; background-color: " session.track.color ";")}}>
<div class="ui fluid padded" style={{concat "color: " session.track.fontColor "px; background-color: " session.track.color ";"}}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the css helper instead of concat

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niranjan94 I've updated the helper. Please review :)

@niranjan94 niranjan94 requested a review from ritikamotwani June 10, 2019 10:42
@abhinavk96 abhinavk96 merged commit 48f19b8 into fossasia:development Jun 10, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the speakerSessionItem branch August 20, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sessions not listed under Speaker on Public Page

7 participants