-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: ensures sessions are listed in public/speakers by handling errors #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensures sessions are listed in public/speakers by handling errors #3093
Conversation
kushthedude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyanshdwivedi The following solves the speaker tab issue too 🎉 , All the speakers are getting loaded on one go , just one improvement i could suggest ,Please remove the highlighting of session name and time , Its looking very weird on the public page

|
@kushthedude actually the highlighting of session name and time depends on track a user selects. You remember while creating an event we used to select track and color? That color is being used here. It signifies the track |
kushthedude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this #3075 is also solved except the dependancy issue ,Which i will see today if i could find any alternatives
f33b547
599b10d to
f33b547
Compare
|
@kushthedude @ritikamotwani I just made a small change on line 64 and force pushed. Lost your review. Please review again |
uds5501
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
| {{/if}} | ||
| </p> | ||
| <div class="ui fluid padded" style={{-html-safe (concat "color: " session.track.fontColor "px; background-color: " session.track.color ";")}}> | ||
| <div class="ui fluid padded" style={{concat "color: " session.track.fontColor "px; background-color: " session.track.color ";"}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the css helper instead of concat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niranjan94 I've updated the helper. Please review :)
dde5888
removes extra space over title if session is not scheduled
dde5888 to
8097b35
Compare
Fixes #3043
Short description of what this resolves:
Session of the Speaker are not getting listed under Its Heading on Public Pages due to :
html-safenot a helper errorChanges proposed in this pull request:
html-safehelperMicrolocationon speaker-item to increase the understanding.Checklist
developmentbranch.