Skip to content

Conversation

@kushthedude
Copy link
Member

Fixes #2966

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label May 27, 2019
@kushthedude kushthedude changed the title fix: Addition of Event End Date on Public Event Page [WIP] Addition of Event End Date on Public Event Page May 28, 2019
@auto-label auto-label bot removed the fix label May 28, 2019
@kushthedude kushthedude changed the title [WIP] Addition of Event End Date on Public Event Page fix: Addition of Event End Date on Public Event Page May 28, 2019
@auto-label auto-label bot added the fix label May 28, 2019
@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 @ritikamotwani @pradeepgangwar Review Please .
PS-: Please merge #3021 to see the proper function of this

@kushthedude
Copy link
Member Author

@niranjan94 Have a look now

@shreyanshdwivedi
Copy link
Member

@kushthedude travis build is failing. Please fix this

@kushthedude
Copy link
Member Author

@kushthedude travis build is failing. Please fix this

@shreyanshdwivedi Sure,Some minor lintink issue , just doing some final tests for Boundary Conditions will finalise in few minutes

@kushthedude
Copy link
Member Author

@CosmicCoder96 Please Review

@shreyanshdwivedi
Copy link
Member

@kushthedude it would be great if screenshots for both desktop amd mobile view are attached here

Co-Authored-By: Niranjan Rajendran <[email protected]>
@kushthedude
Copy link
Member Author

@shreyanshdwivedi - :
In Desktop View:

Screenshot 2019-05-29 at 4 45 46 AM

In Mobile View:
Screenshot 2019-05-29 at 4 45 41 AM

@kushthedude
Copy link
Member Author

@shreyanshdwivedi @mrsaicharan1 @uds5501 @CosmicCoder96 Please Review

@kushthedude
Copy link
Member Author

@CosmicCoder96 Review please

@uds5501
Copy link
Contributor

uds5501 commented May 30, 2019

@kushthedude did you try using muted text ? I think that may serve the purpose without any additional CSS.

@kushthedude
Copy link
Member Author

kushthedude commented May 30, 2019 via email

@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 Please Review

@kushthedude kushthedude changed the title fix: Addition of Event End Date on Public Event Page feat: Addition of Event End Date on Public Event Page Jun 2, 2019
@auto-label auto-label bot added feature and removed fix labels Jun 2, 2019
@kushthedude
Copy link
Member Author

@niranjan94 @CosmicCoder96 Review Please

@abhinavk96 abhinavk96 merged commit dfdf68e into fossasia:development Jun 4, 2019
@kushthedude kushthedude deleted the test branch July 13, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public Event Page should show beginning and end date if event is over several days

5 participants