Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented May 25, 2019

Fixes #3012

Short description of what this resolves:

We are implementing feature to provide ability to a user to delete his/her account. If the user is associated with any event, he/she must be given choice to transfer the events to other organizers associated with the event.

Changes proposed in this pull request:

  • Adds a settings option which will have option to transfer ownership of an event to other user
    ezgif com-video-to-gif(2)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kushthedude
Copy link
Member

@shreyanshdwivedi Just a suggestion , Semantic-UI provides various designing patterns for the UI header and UI Segments and more , See if you can use Red Segments for this section to make it more look-a-like to Github Danger Zone

@shreyanshdwivedi
Copy link
Member Author

@uds5501 @kushthedude I might need some help here. Actually the events-transfer-modal is coming up as plain html rather than being a modal. Can you guys point me what am I missing here?
Screenshot_2019-05-27 Settings Apk19 Events Open Event

@kushthedude
Copy link
Member

@uds5501 @kushthedude I might need some help here. Actually the events-transfer-modal is coming up as plain html rather than being a modal. Can you guys point me what am I missing here?
Screenshot_2019-05-27 Settings Apk19 Events Open Event

@shreyanshdwivedi Incorrect File Name is all the cause buddy 😆

@shreyanshdwivedi
Copy link
Member Author

@kushthedude thanks for pointing out my silly mistake 🤣

@shreyanshdwivedi
Copy link
Member Author

@uds5501 the frontend PR is almost completed now. It only needs the endpoint now. I'm sending the event to be transferred and the email of the new organizer as payload. Please take a look and make the endpoint based on it. And please reference the server PR here

@uds5501
Copy link
Contributor

uds5501 commented May 28, 2019

@shreyanshdwivedi understood, will link the PR over here and carry on the server implementation accordingly

@shreyanshdwivedi shreyanshdwivedi force-pushed the danzerZone branch 2 times, most recently from 6fef444 to 223c18a Compare June 5, 2019 05:57
@uds5501
Copy link
Contributor

uds5501 commented Jun 5, 2019

@shreyanshdwivedi please change the payload to :

        data: {
          attributes: {
            'new-organizer': data.newOrganizerEmail,
            'starts-at'    : event.startsAt,
            'ends-at'      : event.endsAt,
            'timezone'     : event.timezone
          },
          id: event.originalId, 
          type: 'event',
          identifier: event.id
        }

This passes the schema validation checks and I can work on the before_patch hook after this

@shreyanshdwivedi shreyanshdwivedi force-pushed the danzerZone branch 2 times, most recently from cb7eea0 to e7af880 Compare June 5, 2019 07:21
@shreyanshdwivedi
Copy link
Member Author

@uds5501 I've updated the PR. Also I've changed new-organiser to new-owner. Please update your server implementation accordingly

@mariobehling
Copy link
Member

mariobehling commented Jun 11, 2019

@shreyanshdwivedi Please also update the text about the account deletion:

Your account currently cannot be deleted as active events and/or orders are associated with it. Before you can delete your account you must transfer the ownership of your event(s) to another organizer or cancel your event(s). If you have ticket orders stored in the system, please cancel your orders first too.

@shreyanshdwivedi
Copy link
Member Author

shreyanshdwivedi commented Jun 14, 2019

@uds5501 @CosmicCoder96 This PR is completed now. I've implemented a role-invite for transferring event and opened a server PR for handling role invite for owner role - fossasia/open-event-server#6048
These both PRs can be merged only after owner is added as a role on server via this PR - fossasia/open-event-server#6042

ezgif com-video-to-gif(2)

@shreyanshdwivedi shreyanshdwivedi changed the title [WIP] feat: transfer ownership of event to another user feat: transfer ownership of event to another user Jun 14, 2019
@auto-label auto-label bot added the feature label Jun 14, 2019
@shreyanshdwivedi
Copy link
Member Author

@CosmicCoder96 I've made the required change. Please review

@shreyanshdwivedi
Copy link
Member Author

@CosmicCoder96 updated the async-await logic. Please review

@shreyanshdwivedi
Copy link
Member Author

@CosmicCoder96 @niranjan94 please review

@shreyanshdwivedi shreyanshdwivedi force-pushed the danzerZone branch 2 times, most recently from e8cb2f0 to 97e3a7e Compare June 21, 2019 16:38
@shreyanshdwivedi
Copy link
Member Author

@niranjan94 I've made the changes. Please review

fixes travis failure

Introduces async-await
@shreyanshdwivedi
Copy link
Member Author

@niranjan94 added eventName to computed properties. Please check

@niranjan94
Copy link
Member

@shreyanshdwivedi this PR contains DO-NOT-MERGE label. Is the label still valid ?

@shreyanshdwivedi
Copy link
Member Author

Let's not merge it for now. It depends on PR fossasia/open-event-server#6042
Please review it too @CosmicCoder96 @niranjan94
It is a big change so needs a thorough check

@abhinavk96 abhinavk96 merged commit 8b24fc4 into fossasia:development Jul 3, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the danzerZone branch July 3, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transfer the ownership of your events to another organizer.

7 participants