Skip to content

Conversation

mohitm15
Copy link
Contributor

@mohitm15 mohitm15 commented May 7, 2019

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

It displays the option box like edit,view,delete,activate,deactivate on the event overview horizontally in the mobile view.

Changes proposed in this pull request:

  • Update files by adding conditions for mobile view. Changed files are listed in the pull request.

Screenshot

Screenshot 2019-04-13 22:41:48

Fixes #2541

@kushthedude
Copy link
Member

@mohitm15 Dont you even check the git status before pushing a pr , Remove the Conflicts and squash your commits.

@kushthedude
Copy link
Member

Squash your commits @mohitm15

@kushthedude
Copy link
Member

Your PR has parsing error do local tests before pushing @mohitm15 , How much more you need for this issue , dont just blindly push commits ?

@kushthedude
Copy link
Member

@mohitm15 Are you still there or just busy with random stuff ?

@mohitm15
Copy link
Contributor Author

mohitm15 commented May 8, 2019 via email

@kushthedude
Copy link
Member

? Status

@mohitm15
Copy link
Contributor Author

mohitm15 commented May 9, 2019

? Status

Just reached home, making changes accordingly!

@kushthedude
Copy link
Member

kushthedude commented May 9, 2019

@mohitm15 Squash the commits

@abhinavk96 abhinavk96 merged commit a543dbc into fossasia:development May 10, 2019
@mohitm15 mohitm15 deleted the branch15 branch May 11, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aligning the options to preview, edit event boxes horizontally in mobile view

3 participants